Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve successful draft save notification for screen readers #37683

Merged
merged 3 commits into from Jan 3, 2022
Merged

Improve successful draft save notification for screen readers #37683

merged 3 commits into from Jan 3, 2022

Conversation

alexstine
Copy link
Contributor

@alexstine alexstine commented Jan 3, 2022 •
edited

Description

I modified the success save draft notification to be more descriptive for screen readers.

How has this been tested?

Open any Post or Page and select Save draft. Observe how screen readers now announce Draft saved instead of just Saved.

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@alexstine alexstine self-assigned this Jan 3, 2022
@alexstine alexstine added [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jan 3, 2022
@alexstine
Copy link
Contributor Author

As usual, I have no idea why the tests are failing now. Looks unrelated to this PR.

kevin940726
kevin940726 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me 👍 .

I restarted the tests and they passed.

@kevin940726 kevin940726 merged commit e68e4ca into WordPress:trunk Jan 3, 2022
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 3, 2022
@alexstine
Copy link
Contributor Author

Thanks @kevin940726 for the quick review! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@talldan talldan Awaiting requested review from talldan

@aristath aristath Awaiting requested review from aristath

Assignees

@alexstine alexstine

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexstine @kevin940726