Fixed quote paragraph transformations. #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Feature] Blocks
jorgefilipecosta
requested review from
youknowriad,
jasmussen,
ellatrix and
mcsf
youknowriad
approved these changes
Dec 4, 2017
| } ); | ||
| transform: ( { value, citation } ) => { | ||
| // transforming an empty quote | ||
| if ( ( ! value || ! value.length ) && ! citation ) { |
There was a problem hiding this comment.
you're checking ! value here which means the value could be undefined. Should we check the same when we use value.map down here, or maybe just replace it with map?
unless value is always an array and this first check is unnecessary then?
There was a problem hiding this comment.
Nice catch @youknowriad, I also checked for undefined/null on the map.
Before when transforming a quote into a paragraph the result was a a paragraph and the remaining quote. Now the quote is transformed into several paragraphs. The logic was also simplified.
jorgefilipecosta
force-pushed
the
fix/quote-paragraph-transforms
branch
from
ade00a2
to
bd6776a
Compare
This was referenced Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issues #3559 and #1765 affecting quote->paragraph transformations.
Before when transforming a quote into a paragraph the result was a paragraph and the remaining a quote. Now the quote is transformed into several paragraphs. The logic was also simplified.
The strategy used in this PR is identical to the one used to transform between quote and list.
How Has This Been Tested?
Follow the steps described in both issues and verify both are now resolved.
Add an empty a quote verify it transforms to empty paragraph
Add a quote with one line of text verify it transforms to one paragraph.
Add a quote with a citation verify it transforms to one paragraph.
Add a quote with many lines and custom formats (e.g bold links etc...) verify it transforms each line to a paragraph the citation if present is the last paragraph.
Screenshots: