normaliseBlocks: Don't break between inline siblings #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
added
the
[Feature] Raw Handling
|
Looks good to me in latest Chrome on mac and in latest Firefox on mac.
<p><strong>Letterpress printing</strong> is a technique of <a href="https://en.wikipedia.org/wiki/Relief_printing">relief printing</a> using a <a href="https://en.wikipedia.org/wiki/Printing_press">printing press</a>, a process by which many copies are produced by repeated direct impression of an inked, raised surface against sheets or a continuous roll of paper.<sup><a href="https://en.wikipedia.org/wiki/Letterpress_printing#cite_note-Encyclop.C3.A6dia_Britannica-1">[1]</a></sup> A worker composes and locks <a href="https://en.wikipedia.org/wiki/Movable_type">movable type</a> into the "bed" or "chase" of a press, <a href="https://en.wikipedia.org/wiki/Ink">inks</a> it, and presses paper against it to transfer the ink from the type which creates an impression on the paper.</p> |
ellatrix
reviewed
Dec 7, 2017
| // Require that the first character be a letter. This notably | ||
| // prevents footnote markings ([1]) from being caught as | ||
| // shortcodes. | ||
| tag: '[a-z][a-z0-9_-]*', |
There was a problem hiding this comment.
This whole line looks a bit add to me... maybe I missed some conversation. There is now a fallback block block for unhandled shortcodes? What if they are inline shortcodes? I'll maybe open a new ticket, sorry. :)
There was a problem hiding this comment.
Correct, see #3610.
Inline shortcodes are definitely a problem. I’d be grateful if you could weigh in on #3806 (comment) !
ellatrix
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When pasting rich content, blocks are split where new inline elements start, such as
<a>:How Has This Been Tested?
Copy the first paragraph from Wikipedia's entry on letterpress printing, paste to an empty post. Make sure that only one Paragraph is created, and that no formatting or content was lost from the source.
Types of changes
Checklist: