[Block Library]: Remove unnecessary usages of RawHTML
#38527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Package] Block library
|
Size Change: +24 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Feb 6, 2022
ntsekouras
force-pushed
the
remove/unnecessary-rawhtml-usages-from-blocks
branch
from
d16e2bb
to
a2c43b9
Compare
gziolo
approved these changes
Feb 7, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #38451
It seems in some cases we don't need to use
RawHTMLcomponent as it creates an extradiv. This PR just does that and usesdangerouslySetInnerHTMLdirectly - which is whatRawHTMLuses anyway.Testing instructions
Query Loopblock add thePost Titleblock (this PR affects only the readonly view) and observe in the dev tool the html markup that an extradivis not rendered.Latest Postsblock and observe the same as above in dev tools for the post title andfullcontent(have to enable it through inspector controls).This PR doesn't change anything in the front end.