Editor store: remove a noop SETUP_EDITOR action #38622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -11 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
jsnajdr
force-pushed
the
remove/editor-setup-editor
branch
from
f65efc6
to
19498fb
Compare
|
Added removal/deprecation of one more action: |
youknowriad
reviewed
Feb 8, 2022
| type: 'RESET_POST', | ||
| post, | ||
| }; | ||
| export function resetPost() { |
There was a problem hiding this comment.
This feels like an action that could potentially be used by third party plugins, it would be good to try to find usage in wpdirectory.net before making this breaking change.
Alternatively, we can also consider deprecating it but keeping its behavior.
There was a problem hiding this comment.
I searched in wpdirectory.net and haven't found any usage of resetPost.
Even if it was used, what would it be supposed to do? The action used to reset the entire post with all attributes (content, title, ...) to a new value, but today it can change just the ID and type. Everything else has moved to the core store. And can resetPost be really used to completely reinitialize the editor with an entirely new post ID? I doubt that it's so easy and that setting "current post ID" in editor state is enough.
I can modify the patch to keep the RESET_POST reducer behavior -- my main goal is to remove the redundant resetPost call from setupEditor.
There was a problem hiding this comment.
Thanks for looking, let's keep it that way and adapt if we ever receive any feedback about this.
youknowriad
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
dispatch( editorStore ).setupEditoraction, this PR removes the dispatch of theSETUP_EDITOReffect/action. There is no effect registered or a reducer reacting to this action type, so it's a noop. There is only aSETUP_EDITOR_STATEaction that is active.Stumbled upon this when working on #35929, migrating the
editorstore to thunks.