Improve consistency of Navigation block hook #38705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
8 tasks
|
Size Change: -2 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
E2E failures seem related, but I restarted them anyway – let's see what happens. |
Remove "entity" in favour of "menu" Attempt to fix failing e2e test
getdave
force-pushed
the
update/improve-consistency-of-nav-hook
branch
from
70b8cdb
to
6a93603
Compare
|
Ok @adamziel I'm finished with the renaming. Can I get a confidence ✅ here pls 🙏 |
adamziel
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #38627 (comment) we learnt that the
useNavigationMenuhook was inconsistent in its use ofnavigationvsnavigationMenuin it's variable naming.This PR aims to normalize everything exported by the hook towards the "Navigation Menu" terminology.
Testing Instructions
Check everything works as before. Particular check the permissions around the block.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).