Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NumberControl validation #39260

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Draft

Fix NumberControl validation #39260

wants to merge 6 commits into from

Commits on Mar 7, 2022

  1. Have InputControl avoid calling onChange for invalid values 

    Also use the blur event to commit invalid values allowing extending
components like `NumberControl` to resolve the value on commmit.
    @stokesman
    stokesman committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    02fa657 View commit details
    Browse the repository at this point in the history

  2. Add tests for new number control behavior

    @stokesman
    stokesman committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    6c8d88a View commit details
    Browse the repository at this point in the history

  3. Validate on InputControl change events when not isPressEnterToChange

    @stokesman
    stokesman committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    1e9f30f View commit details
    Browse the repository at this point in the history

  4. Update invalidate action to include value in payload

    @stokesman
    stokesman committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    68eaa61 View commit details
    Browse the repository at this point in the history

  5. Throw from onValidate when NumberControl holds an invalid value

    @stokesman
    stokesman committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    90a5893 View commit details
    Browse the repository at this point in the history

  6. Use onValidate of NumberControl to update state in RangeControl

    @stokesman
    stokesman committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    fcd79b9 View commit details
    Browse the repository at this point in the history