Add some tests for TreeGrid. Update README to reflect latest functionality. #39302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstine
added
[Type] Enhancement
alexstine
commented
Mar 9, 2022
| @@ -275,6 +275,10 @@ function TreeGrid( | |||
| ); | |||
| focusablesInNextRow[ nextIndex ].focus(); | |||
|
|
|||
| // Let consumers know the row that was originally focused, | |||
There was a problem hiding this comment.
I guess this was missed in the original PR review. My bad.
| @@ -97,16 +97,16 @@ describe( 'TreeGrid', () => { | |||
| </TreeGrid> | |||
| ); | |||
|
|
|||
| screen.getByText( 'Row 2' ).focus(); | |||
| const row2Element = screen.getByText( 'Row 2' ).closest( 'tr' ); | |||
| screen.getByText( 'Row 1' ).focus(); | |||
There was a problem hiding this comment.
This was necessary as row 1 will do the collapsing/expanding now.
|
Size Change: -15 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Mar 9, 2022
There was a problem hiding this comment.
Thank you as always, @alexstine!
Changes LGTM, although let's wait for @talldan 's review in case they have anything to add :)
One small note — could you just add an entry to the @wordpress/components CHANGELOG mentioning the change to the onFocusRow callback?
talldan
approved these changes
Mar 9, 2022
8 tasks
|
I cherry-picked this PR into Gutenberg 12.8 release to prevent issues with the merge conflicts in the CHANGELOG file while publishing to npm with the automated script. |
gziolo
pushed a commit
that referenced
this pull request
Mar 11, 2022
…ality. (#39302) * Start working on updating/implementing new tests. * Update README docs. * Add tests for Home/End. Fix missing onFocus consumer for Home/End. * Add item to changelog. * A few more changelog details. * Fix changelog formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The PR is adding some missing unit tests for the TreeGrid component. It is also clearing up the README.
Why?
Chores are important to keep our code working. 👍
How?
Hopefully all checks will turn green and there will be more test data to prevent against regressions in the future.
Testing Instructions
Wait for PR checks to turn green or test locally with the below command.
Screenshots or screencast