Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitControl: refactor unit tests to TypeScript and modern RTL #39341

Closed
wants to merge 13 commits into from
Closed

UnitControl: refactor unit tests to TypeScript and modern RTL #39341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d471426
Include TypeScript tests in TSConfig
ciampo Mar 9, 2022
fd07e7b
Add `@jest/globals` to dev dependencies
ciampo Mar 9, 2022
3c8064a
Rename `utils.js` to `utils.ts`
ciampo Mar 9, 2022
afd07e3
Tweak `UnitControl` s utils
ciampo Mar 9, 2022
4e2696f
Fix TypeScript errors in utils tests
ciampo Mar 9, 2022
b0a8cec
Rename `index.js` to `index.tsx`
ciampo Mar 9, 2022
6709b55
Update `index.tsx` to fix most TypeScript errors
ciampo Mar 10, 2022
4c29328
Fix type problems with jest, testing-library, snapshot-diff
sirreal Mar 11, 2022
441816d
Remove dev dependencies from components's package.json
ciampo Mar 11, 2022
ec16572
Ignore eslint error about missing dependency in package.json
ciampo Mar 11, 2022
2395cdf
setup test ts project
sirreal Mar 11, 2022
15ff9dd
Add `@emotion/core` to test config
ciampo Mar 11, 2022
21a7e52
Require `snapshot-diff` in testing-library setup file
ciampo Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 33 additions & 0 deletions packages/components/src/unit-control/test/__snapshots__/index.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`UnitControl Basic rendering should render custom className 1`] = `
Snapshot Diff:
- First value
+ Second value

@@ -1,10 +1,10 @@
<div
class="components-unit-control-wrapper css-aa2xc3-Root e1bagdl33"
>
<div
- class="components-flex components-input-control components-number-control components-unit-control e1bagdl32 ep48uk90 em5sgkm7 css-18wzek1-View-Flex-sx-Base-sx-Items-ItemsColumn-Root-rootLabelPositionStyles-Input-ValueInput-arrowStyles-paddingStyles em57xhy0"
+ class="components-flex components-input-control components-number-control components-unit-control hello e1bagdl32 ep48uk90 em5sgkm7 css-18wzek1-View-Flex-sx-Base-sx-Items-ItemsColumn-Root-rootLabelPositionStyles-Input-ValueInput-arrowStyles-paddingStyles em57xhy0"
data-wp-c16t="true"
data-wp-component="Flex"
>
<div
class="components-flex-item em5sgkm3 css-1fmchc6-View-Item-sx-Base-LabelWrapper em57xhy0"
@@ -15,11 +15,11 @@
class="components-input-control__container css-1sy20aj-Container-containerDisabledStyles-containerMarginStyles-containerWidthStyles em5sgkm6"
>
<input
autocomplete="off"
class="components-input-control__input css-117vub9-Input-dragStyles-fontSizeStyles-sizeStyles em5sgkm5"
- id="inspector-input-control-1"
+ id="inspector-input-control-2"
inputmode="numeric"
max="Infinity"
min="-Infinity"
step="1"
type="number"
`;