Pullquote block: Remove deprecated pullquote style #39413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -53 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
ndiego
changed the title
carolinan
reviewed
Mar 14, 2022
|
Thanks for reviewing @carolinan, I'll give it a day or so and rebase to try and clear the failing test. It appears unrelated. |
aristath
approved these changes
Mar 18, 2022
ndiego
force-pushed
the
fix/remove-pullquote-deprecated-style
branch
from
6412bed
to
ae42516
Compare
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.is-style-solid-colorpullquote style has been deprecated for some time. However, in thestyle.cssfile for the pullquote block, there was also a deprecated style for every other pullquote without this class (i.e..wp-block-pullquote:not(.is-style-solid-color){...}). This is problematic and prevents you from setting the background color for pullquotes intheme.json.This PR leaves the deprecated styles for
.is-style-solid-colorintact, but removes any other styling that impacts other pullquote blocks. The.is-style-solid-colorstyling is left untouched in case there are still some users utilizing this. That said, complete removal should be considered in the future.Testing Instructions
theme.jsonapply a background color to pullquote blocks.theme.json.Example code for adding a background color in theme.json.