Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option to show or hide empty categories #39426

Merged
merged 4 commits into from Apr 14, 2022

Conversation

mauriac
Copy link
Member

@mauriac mauriac commented Mar 14, 2022

What?

New option to show or hide empty categories (non-breaking change which adds functionality)

Why?

Fixes #35489

How?

Testing Instructions

Screenshots or screencast

Screenshot at Mar 14 15-49-07

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 14, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mauriac! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@skorasaurus skorasaurus added the [Block] Categories Affects the Categories Block label Mar 24, 2022
When "Show empty categories" is checked empty categories do not show
and vice versa. This post fix that behavious.
@ntsekouras ntsekouras added [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement. labels Apr 14, 2022
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mauriac! Besides the indentation change this looks good!

packages/block-library/src/categories/block.json Outdated Show resolved Hide resolved
@amustaque97
Copy link
Member

Thank you once again @mauriac for working on this. Let's wait for the pipeline to finish and if there are no errors. Will merge it.

@amustaque97 amustaque97 merged commit 45981a6 into WordPress:trunk Apr 14, 2022
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 14, 2022
@mauriac
Copy link
Member Author

mauriac commented Apr 14, 2022

@amustaque97 thanks for handling this... Please what is Gutenberg policy about branch deleting? Should I leave the branch for history or delete it to maintain the repository clean?
Thank you again.

@Mamaduka
Copy link
Member

@mauriac, feel free to delete the branch 👍

@mauriac mauriac deleted the update/categories-block branch April 14, 2022 13:12
@bph bph added the Needs User Documentation Needs new user documentation label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Categories Affects the Categories Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs User Documentation Needs new user documentation [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No "hide_empty" setting on Categories block
6 participants