FocalPointPicker: stop using UnitControl's deprecated unit prop
#39504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
|
Size Change: +7 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
refactor/focal-point-picker-unit-prop
branch
from
b04e255
to
c345820
Compare
ciampo
force-pushed
the
refactor/focal-point-picker-unit-prop
branch
from
c345820
to
9810707
Compare
stokesman
approved these changes
Mar 16, 2022
Comment on lines
-45
to
+51
| value={ valueX } | ||
| value={ [ valueX, '%' ].join( '' ) } | ||
| onChange={ ( next ) => handleChange( next, 'x' ) } | ||
| dragDirection="e" | ||
| /> | ||
| <UnitControl | ||
| label={ __( 'Top' ) } | ||
| value={ valueY } | ||
| value={ [ valueY, '%' ].join( '' ) } |
There was a problem hiding this comment.
Is there something I don't know about join that makes it better than template literals?
There was a problem hiding this comment.
I prefer the join approach because it ignores undefined values:
[ 41, undefined ].join(''); // '41'
`${ 41 }${ undefined }`; // '41undefined'And so I've taken the habit of using this syntax, especially when in need of concatenating quantity and unit in the context of UnitControl
There was a problem hiding this comment.
Now I get it. Thanks! I'm pretty sure in this case the values cannot be undefined but I'm not sweating these joins staying put.
There was a problem hiding this comment.
I prefer the join approach because it ignores undefined values
Oh, nice! I'm sure I'll borrow that approach 😀
ciampo
force-pushed
the
refactor/focal-point-picker-unit-prop
branch
from
9810707
to
29a7c0f
Compare
andrewserong
approved these changes
Mar 17, 2022
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
…WordPress#39504) * `FocalPointPicker`: stop using `UnitControl`'s deprecated `unit` prop * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Related to #39503 , this PR refactors the
FocalPointPickercomponent to avoid using the deprecatedunitprop from theUnitControlcomponent.Why?
The
unitprop is marked as deprecated, the component's docs recommend passing the unit directly through thevaluepropHow?
Refactor the code to pass the unit directly through the
valuepropTesting Instructions