Fix UnitControl resets unit when value is cleared
#39531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
force-pushed
the
fix/unit-control-resets-unit-on-clear
branch
from
e383f1b
to
5415096
Compare
stokesman
added
[Package] Components
ciampo
requested review from
mirka,
ciampo and
andrewserong
and removed request for
ajitbohra
ciampo
moved this from In progress (owned) ⏳
to In progress ⏳ (un-owned)
in WordPress Components
ciampo
reviewed
Mar 17, 2022
There was a problem hiding this comment.
Apologies in case this PR wasn't ready for review, but I thought I'd give it a look anyway 😅
I tested the changes in this PR and they work as per instructions 🚀
Before
unit-control-unit-reset-before.mp4
After
unit-control-unit-reset-after.mp4
It'd be great if we could add a unit test to avoid future regressions — what do you think?
Finally, we'll also need to add an entry to the CHANGELOG for this bug fix.
|
Thanks for testing this out! I do think it was mostly ready for review but indeed I think a unit test and changelog entry are warranted. I'll get to that but later in the day tomorrow at earliest. I've got to prioritize some other stuff for now. |
There was a problem hiding this comment.
Thanks so much for picking this one up @stokesman! This is testing nicely for me so far, too, great that it's a straightforward fix.
+1 Good to add in unit tests, though 🙂
stokesman
force-pushed
the
fix/unit-control-resets-unit-on-clear
branch
from
5415096
to
917344b
Compare
|
Size Change: +5 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
ciampo
force-pushed
the
fix/unit-control-resets-unit-on-clear
branch
from
917344b
to
eebe7a8
Compare
ciampo
force-pushed
the
fix/unit-control-resets-unit-on-clear
branch
from
eebe7a8
to
ba85ce3
Compare
ciampo
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
LGTM 🚀 Thank you @stokesman !
- Tests well in storybook and in the editor
- New unit tests pass (they fail as expected when I remove the fix included in this PR)
I pushed a quick commit to solve a CHANGELOG conflict.
We can merge this PR as soon as CI checks pass
WordPress Components
automation
moved this from In progress ⏳ (un-owned)
to In progress (owned) ⏳
Mar 21, 2022
|
Thanks for testing and reviewing @ciampo and @andrewserong! |
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
* Avoid setting unit from effect hook if parsed to `undefined` * Add unit test * Add changelog entry * Remove duplicated `Bug Fix` section in the CHANGELOG Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevents reset of the unit when the quantity input is cleared in
UnitControl.Why?
I believe this will mostly resolve #38872. Some instances of the issue may be due to components still passing the deprecated
unitprop toUnitControlbut those are being fixed in separate PRs. For instance, I noticed that the border radius control was not fixed by this PR but if the change from #39549 is applied on top of this then it is fixed.How?
Does not set the unit from parsed value prop if the unit returned by the parse is
undefined.Testing Instructions
Try the
UnitControlcomponent in storybook or border width controls in the block editor.