Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document: add the default database password to the getting started document #39780

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

AlanSyue
Copy link
Contributor

What?

Add the default database password to the getting started document.

Why?

I followed the getting started document and I have built the local WordPress environment and Gutenberg successfully.

When I wanted to access the MySQL database, I couldn't connect to the database through the connection information from the document.

Host: 127.0.0.1
Username: root
Database: wordpress
Port: {MYSQL_PORT_NUMBER}

I found that I should use the password then I can access the database.

I think we should add the default password to the document to allow the contributors set up the environment easily.

How?

I add the default database password to the getting started document. When the contributors want to connect to the database, they will note that they should use the password to access the database.

Testing Instructions

  1. build the local WordPress environment.
npm run wp-env start

> gutenberg@12.8.1 wp-env /Users/alansyue/gutenberg
> wp-env "start"

WordPress development site started at http://localhost:8888/
WordPress test site started at http://localhost:8889/
MySQL is listening on port 60967
MySQL for automated testing is listening on port 60965

 ✔ Done! (in 143s 292ms)

image

  1. use the Sequel Ace to access the database

using password: NO

image

Access denied
image

using password: YES

image

Access the database successfully
截圖 2022-03-26 下午8 35 40

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 26, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AlanSyue! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Mar 26, 2022
Copy link
Contributor

@alexstine alexstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alexstine alexstine merged commit a18d2dd into WordPress:trunk Mar 30, 2022
@alexstine
Copy link
Contributor

@AlanSyue Thanks for the PR.

Just merged this one in. Seems like good improvement to me. 👍 Hope to see further contributions in the future.

@AlanSyue AlanSyue deleted the doc/mysql-env-setup branch March 30, 2022 15:53
@AlanSyue
Copy link
Contributor Author

@alexstine
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants