[List v2]: Handle Enter in empty list items #39858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
oandregal,
ellatrix and
jorgefilipecosta
|
Size Change: +474 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Mar 29, 2022
|
I like this behaviour :) |
ZebulanStanphill
added
[Block] List
ellatrix
reviewed
Mar 30, 2022
| } | ||
| event.preventDefault(); | ||
| if ( canOutdent ) { | ||
| outdentListItem(); |
There was a problem hiding this comment.
Why? It's working as expected in the video, no?
There was a problem hiding this comment.
For me it was indenting for some reason instead of outdenting.
ellatrix
approved these changes
Mar 30, 2022
|
@ntsekouras In a separate PR, can you do the same thing for |
|
Sweet! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #39519
Alternative of: #39626
Based on @mtias's suggested algorithm here: #39626 (comment)
Screeny.Video.28.Mar.2022.at.13.50.44.mov
In the experimental new list blocks we should split lists on empty list items if we press enter.
How?
Since my first approach with a different algorithm, the indentation has been implemented by @jorgefilipecosta and I'm using one of the hooks for one of the two parts of the algorithm.
Testing Instructions
EnterScreenshots or screencast
Screen.Recording.2022-03-29.at.5.41.09.PM.mov
Notes
Enterin a non empty list item is not handled yet, as it needs more changes involving the RichText API.hooksfile and moveduseIndentListItem and useOutdentListItemwithout making any change. The new hook is theuseEnterone.