Hide block movers in new navigation sidebar #40039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: -6 B (0%) Total Size: 1.22 MB
鈩癸笍 View Unchanged
|
getdave
added
the
[Feature] Navigation in Site View
getdave
approved these changes
Apr 5, 2022
priethor
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As a temporary measure while #39802 is a problem, this hides the block movers in the new site editor navigation sidebar.
Why?
It's good to not ship features that have known accessibility issues. 馃槃
The block movers in List View are pretty raw having been inactive for a long time. It'd be good to test and fix any issues with them before introducing them. I'm also unsure of the motivation behind enabling them in this new feature, but keeping them inactive in the main List View sidebar.
How?
Deletes the
showBlockMoversprop.Testing Instructions
You'll need an existing Navigation Menu to test, so if you don't have any, create one first in the navigation block. Then:
Screenshots or screencast
Before
After