Update post content placeholder #40177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Block] Post Content
|
Size Change: +424 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
One nitpick, but it'd be nice if we could have copy that started with a proper paragraph and not two sentences, which would be a more accurate representation of real content and easier to work with when building or customizing templates. |
|
It's important to remember that this block can render in a static state when editing a template without context. For example when you open the Single Post template in the Site Editor. In that case the suggested placeholder content seems a little arbitrary.
Isn't it unlikely that folks will encounter this block without already being familiar with WordPress, and blocks for that matter?
Yet this block has none of those options 😬
You cannot write anything inside this block unless the template has loaded context. I don't have a better suggestion right now, but I would say we either need a different placeholder for this case, or one that is more generic so that it makes sense in both scenarios. |
|
A more generic alternative to consider:
|
|
Valid points. I like the new text, I will update the PR shortly. |
|
Should we get a copy review? 🤔 |
carolinan
added
the
Needs Copy Review
|
Hello! Editorial had a copy review ping so here I am. :) My suggestion would be to keep this quite simple: Welcome to Post Content! This is where all the blocks you have used will be displayed on one page — paragraph, image, video, table — or any other type of block utilized (including custom). |
mtias
added
the
Backport to WP Beta/RC
|
Once we are happy with this let's consider it for backport given it's primarily just a copy change. |
|
How about "This is the Post Content block. It will display all the blocks in any single post, page or custom post type — paragraph, image, video, table — or any other type of block." |
Is that part superfluous? The previous sentence already stated that all blocks will be displayed. |
|
Will that single paragraph "give the impression of content" or will it be too short? |
|
I'm not sure there's all that much difference between one and two lines here :D If we want to resemble post content it really needs to be a couple of short paragraphs imo. Obviously things get a bit verbose if we do that though. |
|
Just checking in on this one @carolinan. How close are we to getting this merged? Trying to organize all the PRs that need backporting this morning. Thanks! |
|
I don't believe I am the one who decides when we are happy with the text, and we are past the string freeze. |
|
I do find it odd that the comment placeholder is much longer |
The release squad is discussing having a Beta4 before RC1. The WordPress 6.0 development cycle doesn't contemplate a possible Beta4, but considering the Soft String Freeze is at the last Beta before RC, it seems reasonable to me to adjust the Soft String Freeze to the new Beta4 and include this PR in it. |
priethor
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
All the suggestions have been addressed and make perfect sense.
@kristastevens @noahtallen (as you participated in #40178 🙂 ) can you confirm we are good to go with this one, too? cc @annezazu @ndiego
|
No issues here! |
adamziel
pushed a commit
that referenced
this pull request
Apr 29, 2022
* Updated post content placeholder * Update the paragraphs
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP Beta/RC
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a longer text as the post content placeholder.
Partial for #40074
Why?
The current post content placeholder does not look like real content.
How?
Adds a longer text as the post content placeholder in edit.js.
Testing Instructions
Screenshots or screencast
Before:
After: