Update/post author block alignment #40380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align text block options now align both the Image and the text, before it was aligning only the text. Fixes WordPress#35964
|
@michalczaplinski and @c4rl0sbr4v0 Perhaps you can take a look at this PR? |
cbravobernal
requested changes
Aug 29, 2022
There was a problem hiding this comment.
Thanks for your contribution @Alex-Kostov !
I think is not a good idea to add block-specific styles to a common SCSS file. Could we fix this issue only in the post-author context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request is providing an update for the Post Author block.
Currently the Post Author block have an option to align the text left / center / right, however this aligns do not include the image. In this pull request I've updated the code so that when align option is used it align both text and image.
Why?
This PR is fixing this issue 35964
How?
About the details I've used
justify-contentin order to align both text and image.Testing Instructions
Screenshots or screencast
Image after the fix, here we can see that both the text and the image can be aligned at the center.
Video how we can change the alignment
https://drive.google.com/file/d/1MIyz5oggYGeGCf5CQcZWzvS9Z2ecA4p1/view?usp=sharing