Block Styles: Remove unnecessary button role and 'onKeyDown' handler #40427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Focus] Accessibility (a11y)
|
Size Change: -41 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Thanks for the clean up here @Mamaduka Everything tests well with me, including @alexstine's suggestion of removing the tabIndex Keyboard navigation 👍 |
ramonjd
reviewed
Apr 18, 2022
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
|
Thanks for the review, @alexstine, @ramonjd . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes unnecessary button role and
onKeyDownhandler from the block styles item element. Both are leftovers from the time usingdivinstead of the native button (changed in #34522).Why?
The
role="button"is already set for the native button and they correctly trigger theonClickevent when using Enter or Space keys.Testing Instructions
Screenshots or screencast