Dependency Extraction Webpack Plugin: Use OpenSSL provider supported in Node 17+ #40503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Dependency Extraction Webpack Plugin
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
gziolo
changed the title
ocean90
reviewed
Apr 23, 2022
There was a problem hiding this comment.
There's another line with md4 which should probably be updated as well:
Did you test if sha512 is noticeable slower (or faster) than md4? Only asking because the webpack docs mentions xxhash64 as a faster algorithm.
|
Tested in Gutenberg where we create an asset file per every entry point.
It's hard to tell whether there is performance impact using the build in Gutenberg repository. |
gziolo
force-pushed
the
fix/webpack-plugin-node-18
branch
from
80fe6bd
to
bb2f919
Compare
I think xxhash64 is the one that's only implemented in webpack and can be used like you tried it in #36471 (comment)? #36471 (comment) doesn't seem to be case any more. |
True, the issue was that it didn't return the value that could be chained, so I couldn't apply Documentation is missing: https://webpack.js.org/api/compilation-object/#createhash. |
|
I landed this change to fix the issue. We can change the algorithm later. We have another fix coming in #34969 which will also use the same hashing algorithm. |
gziolo
pushed a commit
that referenced
this pull request
May 9, 2022
… output rather than Webpack internal state (#34969) * Use `contentHash` in dependency-extraction-webpack-plugin Webpack 5 recommends using the content hash over the old-style chunk hash for cache invalidation, as the chunk hash can change even if the output does not. dependency-extraction-webpack-plugin will now include the content hash for each content type in the asset file. The `version` field is still present, now as a combined hash for all the content types reported, to maintain backwards compatibility. Fixes #34660 * Don't expose individual assets' contentHashes, it's considered too scary. * Hash assets directly, chunk.contentHash doesn't get updated by minification * Switch hash to match #40503 * Changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #36471.
Why?
How?
I picked
sha512as it was listed in Node.js documentation at https://nodejs.org/api/crypto.html#cryptocreatehashalgorithm-options:I'm more than happy to change that if there is something that is better.
Testing Instructions
npx wp-script buildand ensure that it doesn't error.