Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an alignment issue with the post comments form #40613

Merged
merged 1 commit into from May 3, 2022

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Apr 26, 2022

What?

This is the equivalent of #40582 but for the comments form.
Assures that the alignment setting in the block toolbar works for the form elements.
Does not solve the alignment of the comment reply title.

Partial for #40576

Why?

The block had two CSS class names that were missing a single space between them, which meant that the CSS did not apply. Because of this, the alignment option did not work.

How?

By adding a space between the CSS class names.

Testing Instructions

  1. Add a posts comment form block in the editor
  2. Adjust the alignment from the block tool bar. Duplicate the block and select a different alignment -repeat this for every alignment
  3. Save and view the front.
  4. Confirm if the alignments in the editor and front match the toolbar setting.

Screenshots or screencast

For the before shot, please see the issue.
With the PR applied:

The form text elements and the submit button are centered, but the "Leave a Reply" heading is not.

@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Post Comments Form Affects the Comments Form Block labels Apr 26, 2022
@carolinan carolinan marked this pull request as ready for review April 26, 2022 12:21
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbravobernal cbravobernal merged commit 690326d into trunk May 3, 2022
@cbravobernal cbravobernal deleted the update/post-comments-form-classes branch May 3, 2022 15:11
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone May 3, 2022
@ockham ockham added the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label May 6, 2022
@gziolo
Copy link
Member

gziolo commented May 6, 2022

Cherry-picked for WordPress 6.0 RC2 release with 5fac2d7.

@gziolo gziolo removed the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label May 6, 2022
gziolo pushed a commit that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Comments Form Affects the Comments Form Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants