Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments block: Fix glitches found while backporting #40628

Merged
merged 3 commits into from Apr 29, 2022

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Apr 26, 2022

What?

Address glitches mentioned in #34994 (comment).

Why?

Those are glitches that need fixing 🙂

How?

Applying the solutions that were suggested there.

Testing Instructions

Verify that #34994 (comment) has been addressed.

@ockham ockham added [Type] Bug An existing feature does not function as intended [Block] Post Comments Form Affects the Comments Form Block [Block] Comments Title Affects the Comments Title Block labels Apr 26, 2022
@ockham ockham self-assigned this Apr 26, 2022
@ockham ockham mentioned this pull request Apr 26, 2022
13 tasks
@ockham ockham marked this pull request as ready for review April 29, 2022 12:11
@ockham ockham requested a review from ajitbohra as a code owner April 29, 2022 12:11
@ockham ockham added the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Apr 29, 2022
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@ockham ockham merged commit e86188d into trunk Apr 29, 2022
@ockham ockham deleted the fix/comments-glitches-found-while-backporting branch April 29, 2022 14:08
@ockham
Copy link
Contributor Author

ockham commented Apr 29, 2022

@adamziel Can we maybe get this one also backported for the Beta 4? 😊

@ockham ockham added this to In progress in Comments Loop block via automation Apr 29, 2022
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone Apr 29, 2022
@adamziel
Copy link
Contributor

Done! 08ad761

@gziolo gziolo removed the Backport to WP Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Apr 30, 2022
@cbravobernal cbravobernal moved this from In progress to Done in Comments Loop block May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Title Affects the Comments Title Block [Block] Post Comments Form Affects the Comments Form Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants