Try: Fix regression with featured images in latest posts. #40662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +43 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Here's a mostly cosmetic companion PR: #40663 |
|
This PR solves the positioning visually, but solving it also introduces an issue that is already present in the editor. |
|
Indeed, the order is all wrong in that setup. However given that issue is already present in the editor, and this PR just fixes the regression where floats didn't work at all, should it not land as a fix to that regression? |
|
To elaborate a bit, I'm fixing this as a regression due to a report where a theme relied on this float rule being present, which is missing as of #38657. It seems to fix the tab-order issue we'd need a separate PR and/or issue. |
carolinan
approved these changes
Apr 28, 2022
|
Thank you. Do you know if the issue you reported is ticketed? Otherwise I'm happy to open one. |
|
CC: @Mamaduka should we backport this one? |
|
Thanks for the ping, @jasmussen. |
|
Created a ticket here: #40686 |
|
I'm adding a backport label for now so this comes up during the triage tomorrow. |
adamziel
added
the
Backport to WP Beta/RC
adamziel
pushed a commit
that referenced
this pull request
Apr 29, 2022
|
I cherry picked this change into |
adamziel
removed
the
Backport to WP Beta/RC
|
👋 I was the one who initially pointed this bug out to Joen, and also just noticed that left alignment is broken not only on the front end, but also in the template editor, but strangely not the page editor. Front end & Template editor: Page editor: Testing Instructions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The Latest Posts block has an option to float featured images left and right:
In the editor, this works:
On the frontend, as of #38657, it doesnt, because the float rule is missing:
This PR restores the float rule, but just for the latest posts block.
Testing Instructions