Fix batchRest not throwing errors in Playwright
#40668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
Is it possible for some parts of a batch to succeed and others fail? If so, then it sounds like it's working correctly. If all the requests fail (which I guess was the case here?), then perhaps that's a case where it might return an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix
batchRestincorrectly swallowing errors.Turns out the batch API will still return 2XX status code even when some of the requests failed. We have to manually check the
failedfield in the response. Not sure if it's a bug or not.This PR also fixes an existing bug in the widgets util. Surprisingly, it didn't affect any of the tests though, maybe we don't need them.
Why?
The bug makes it hard to debug why the API doesn't work in some context.
How?
Check the
failedfield and re-throw the errors.Testing Instructions
CI should pass.