Gallery block: Fix bug with initial image size #41079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
the
[Block] Gallery
|
Size Change: +8 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
May 16, 2022
There was a problem hiding this comment.
This tests well for me! Good catch.
I tested using the same image.
On trunk, here's the default code after insertion. It appears as "Large" in the dropdown, but the link is to the full-sized image:
On this branch, here's the default code after insertion. It appears as "Large" in the dropdown, and the link is to the smaller, "large" image:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The default image size slug for a new gallery is
largeso this PR ensures that the correct corresponding image url is used for this slugWhy?
Currently all new images selected from the media browser default to the full image url instead of the large one.
Fixes: #41072
How?
Passes the full imageData object to the
pickRelevantMediaFilesmethod so the correct image size url can be located.Testing Instructions
Screenshots or screencast
Before:
gallery-imagesize-before.mp4
After:
gallery-imagesize-after.mp4