Testing: Remove snapshot from Post Editor Template Mode test and target expected string instead #41563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et expected string instead
andrewserong
added
[Type] Automated Testing
|
@kevin940726 I've just added you as a reviewer since you worked on the refactor to playwright for this test in #40175. I see the snapshot approach predates the refactor, so happy for feedback on the removal if you think it's safer we don't get rid of the snapshot 🙂 |
kevin940726
approved these changes
Jun 6, 2022
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
andrewserong
deleted the
update/post-editor-template-mode-e2e-test-to-remove-snapshot
branch
|
Thanks for the speedy review! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the snapshot from the
Allow creating custom block templates in classic themestest in the Post Editor Template Mode playwright tests.Why?
While working on #40875, I noticed that whenever I made a change to the classnames that are attached to the group block, this test would fail due to the snapshot test used, which looks at all the markup of the rendered preview, and if any markup has changed, the test fails.
I think, much like the test directly above it, that this test is just wanting to check that the added template is included in the preview. Testing that all markup is identical seems to be a bit outside the scope of this test, and could be making it a little more rigid than needed. So, in this PR, we switch to looking for the expected string within the response.
How?
Just a random paragraph added to the templateinsteadTesting Instructions
Check that the playwright tests pass. You can also attempt to run it locally via: