package.json: bump engines.node version to >=14 #41599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
approved these changes
Jun 8, 2022
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bump the mininum required Node version for the project in package.json's
enginesproperty. The version requirement had been left at>=10.0.0, despite the de facto requirement of 14+, as suggested by.nvmrc.Why?
package.json > engines.nodeand.nvmrc.nvmrcdeclaration is only useful for users who actively usenvmto manage Node versions.engines.noderequirement, users attempting to build Gutenberg typically face confusing build-time errors that are difficult to trace back to the unsatisfied version requirement.npm installwith present an explicit error if the running Node version is outdated:How
Version checking based on
engines.nodeis enforced by NPM'sengine-strictconfig option, originally enabled in #23600.Testing Instructions
npm installon Node 14 and observe that there are no changes in behaviour.npm installon Node 12 and observe that the command fails with an error about the version.