Lodash: Refactor away from _.isArray()
#41652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Status] In Progress
|
Size Change: -22 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
tyxla
added
[Package] Blocks
tyxla
force-pushed
the
remove/lodash-is-array
branch
from
057ee7e
to
946434c
Compare
tyxla
removed
[Status] In Progress
tyxla
requested review from
ntsekouras,
swissspidy,
gziolo,
andrewserong,
fabiankaegy and
chad1008
swissspidy
approved these changes
Jun 10, 2022
ntsekouras
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Lodash's
isArrayis used just a few times in the entire codebase. This PR aims to remove all that usage.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
Removing
_.isArray()is straightforward in favor of the native staticArray.isArray()method and those two are fully compatible with each other, so replacing one with the other is safe.Testing Instructions
Verify all still tests pass.