Scrollable: Convert component to TypeScript #42016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ciampo
approved these changes
Jul 1, 2022
| right: | ||
| otherProps.scrollDirection === 'y' ? 'initial' : 0, | ||
| bottom: args.scrollDirection === 'x' ? 'initial' : 0, | ||
| right: 0, |
There was a problem hiding this comment.
Is this changes on purpose? Previously, the right attribute could also have a value of initial
There was a problem hiding this comment.
Yes the change was intended. In my testing the out of view element was outside the scrollable area. Setting right: 0 made scrollDirection work with all both x, y and auto.
ciampo
moved this from In progress (owned) ⏳
to In progress ⏳ (un-owned)
in WordPress Components
walbo
force-pushed
the
refactor/scrollable-to-typescript
branch
from
30f2c74
to
023d66d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Converts the
Scrollablecomponent to TypeScript.Why?
Part of the @wordpress/components's TypeScript migration (#35744).
How?
Scrollableto TypeScript.Testing Instructions
Scrollablecontinues to function as expected