Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to sample code in gutenberg-examples #42208

Merged
merged 1 commit into from Jul 7, 2022

Conversation

welenofsky
Copy link
Contributor

@welenofsky welenofsky commented Jul 7, 2022

What?

This PR fixes the "finished app" link on this page to point to the updated location of the gutenberg-examples repository sample code. This link changed due to this refactor WordPress/gutenberg-examples@33348e9 and PR: WordPress/gutenberg-examples#195

Why?

The link was changed when the files were reorganized in the example code repository.

How?

I found the example code repository on github and noticed that the directory had changed. I copied the link to this directory and compared it with the link on the site and noticed the difference/created this PR

Testing Instructions

Try to click the new link and verify that it functions correctly and links to the correct location on github.

Fix the link to the finished app code in the gutenberg-examples repository to point to new location. See WordPress/gutenberg-examples@33348e9 or WordPress/gutenberg-examples#195
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @welenofsky! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 7, 2022
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix :)

@fabiankaegy fabiankaegy merged commit 54d0563 into WordPress:trunk Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Congratulations on your first merged pull request, @welenofsky! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts:

https://profiles.wordpress.org/me/profile/edit/

And if you don't have a WordPress.org account, you can create one on this page:

https://login.wordpress.org/register

Kudos!

@github-actions github-actions bot added this to the Gutenberg 13.7 milestone Jul 7, 2022
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants