Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds text decoration support to post title block #42328

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Adds text decoration support to post title block #42328

merged 1 commit into from
Jul 13, 2022

Conversation

draganescu
Copy link
Contributor

What?

Closes #42310. Adds text decoration support to the core post title block.

Why?

Because we want to style via global styles interface or the theme JSON configuration
how the text is decorated in the post title block.

How?

Easy peasy, just added the support directive to the block's JSON configuration.

Testing Instructions

  1. Switch to this branch
  2. Use Empty theme (ideally)
  3. in the theme.json of your theme add
"textDecoration": "underline"

in styles.blocks.core/post-title.typography
4. The post title block should be underlined by default
5. The global styles interface should allow showing the "decoration" panel ans styling
from it.

Screenshots or screencast

[N/A]

@draganescu draganescu changed the title adds text decoration support to post tile block Adds text decoration support to post tile block Jul 11, 2022
@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Block] Post Title Affects the Post Title Block labels Jul 11, 2022
mikachan
mikachan approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you! 🚢

@draganescu draganescu merged commit e4db3d2 into trunk Jul 13, 2022
@draganescu draganescu deleted the add/text-decoration-post-title branch July 13, 2022 08:03
@github-actions github-actions bot added this to the Gutenberg 13.7 milestone Jul 13, 2022
@scruffian
Copy link
Contributor

LGTM

@bph bph changed the title Adds text decoration support to post tile block Adds text decoration support to post title block Jul 15, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 3, 2022
@mburridge mburridge added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Sep 14, 2022
@mburridge
Copy link
Contributor

Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release.

@bph bph mentioned this pull request Oct 3, 2022
Closed
89 tasks
@t-hamano t-hamano mentioned this pull request Dec 18, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@scruffian scruffian Awaiting requested review from scruffian

Assignees
No one assigned
Labels
[Block] Post Title Affects the Post Title Block [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Needs Dev Note Requires a developer note for a major WordPress release cycle Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 13.7
Development

Successfully merging this pull request may close these issues.

Post Title: Add support for textDecoration
5 participants
@draganescu @scruffian @mburridge @mikachan @femkreations