ColorPalette: Fix background image in RTL mode #42510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walbo
added
[Type] Bug
added 2 commits
July 18, 2022 17:44
|
Size Change: -8 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
talldan
reviewed
Jul 19, 2022
| @@ -7,10 +7,12 @@ | |||
| padding: $grid-unit-15; | |||
| font-family: inherit; | |||
| width: 100%; | |||
| /*rtl:begin:ignore*/ | |||
There was a problem hiding this comment.
Thanks for fixing this.
It'd be great to add a comment to say why this is ignored. It would help incidental readers of this code understand what the gradient does.
There was a problem hiding this comment.
Thanks for the review 👍 Comment added.
ciampo
moved this from In progress (owned) ⏳
to In progress ⏳ (un-owned)
in WordPress Components
WordPress Components
automation
moved this from In progress ⏳ (un-owned)
to In progress (owned) ⏳
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix background image in the
ColorPalettecomponent when no color is picked in RTL mode.Why?
Better RTL experience
How?
Don't change the
background-positionvalue in the RTL css file.Testing Instructions
ColorPaletteScreenshots or screencast