Fix Nav block lower permission user tests by removing expectation of REST errors #42556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors were avoided in #42413
getdave
changed the title
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
|
@getdave, it looks like the Navigation block also triggers 403.
|
Can we avoid this now? From my vague memories of working on this it was difficult or impossible to avoid this because there was no way to determine the permissions ahead of making the request for this specific case. |
Yes but mostly it's necessary to manipulate the data. For example, if I"m fetching menu X then the UI expects to allow you to edit it. There's no currently a fool proof way to disable block editing (i.e. "inert" blocks) and so we can use We could use it to fetch the list of existing menus however. But that's still only one request. |
|
It makes sense that we need the I guess we'll have to use a mixed approach, use the |
|
These tests are going to be rewritten so I'll close this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes Nav block user permissions tests by removing expectation that certain REST API endpoints will
403for lower permission users.Why?
I noticed #37604 was reopened (again) and I think this is because the REST errors were removed in #42413. As the requests no longer fire we don't need to expect errors in the tests.
How?
Removes the
toHaveErrored()assertion to cover:Testing Instructions
Re-run the CI tests a few times and ensure that the following test does not fail:
gutenberg/packages/e2e-tests/specs/editor/blocks/navigation.test.js
Line 1320 in 80c536c
Screenshots or screencast