Layout content size controls: add left alignment to line up with description and other elements #42576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ription and other elements
andrewserong
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Jul 21, 2022
aaronrobertshaw
approved these changes
Jul 21, 2022
andrewserong
deleted the
update/tweak-positioning-of-layout-content-size-controls-in-global-styles
branch
andrewserong
added
the
[Feature] Layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A very tiny follow-up to #42309 to make sure the
HStackelements are left aligned in the global styles UI for layout content and wide size controls.Why?
Without setting
justify, too, it looks like theHStackwas defaulting to being centre-aligned. It's very subtle, only a couple of pixels different.How?
justifyprop to the twoHStackcomponents (we could usebottomLeftinalignmentinstead, but personally I have a slight preference to using the CSS properties as it's a little more explicit as to what's happening if you're familiar with flex properties). Happy to change it if need be.Testing Instructions
Open up global styles and go to the Layout panel in the right-hand sidebar. Check that the text for Content now lines up with the description
Set the width of the main content area.and thePaddinglabel.Screenshots or screencast