Shortcuts: add Ctrl+Y for redo on Windows #42627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -62 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
|
@ellatrix thanks so much again for addressing this issue. I'm not sure how we could test the changes, but the code at least looks good to me! |
|
I have tested it and it seems to work fine. d9d004bac4665d903adeaaaa5b51b6e4.mp4 |
|
I think you can test at http://gutenberg.run/42627. |
|
I have tested again at gutenberg.run, and it looks good to me 👍 |
|
Works on our end! Thanks very much again @ellatrix! |
talldan
approved these changes
Jul 27, 2022
| @@ -144,6 +144,8 @@ export const SHIFT = 'shift'; | |||
| */ | |||
| export const ZERO = 48; | |||
|
|
|||
| export { isAppleOS }; | |||
There was a problem hiding this comment.
Not completely convinced about exporting this from keycodes. Maybe there should be a @wordpress/platform package or something.
It's a very minor thing though, so I'll leave it up to you to decide what to do 👍
There was a problem hiding this comment.
Yes, I was wondering also if it's a good idea. But I looked through all the apple checks we're making in Gutenberg, and they're always related to the keyboard, so it seems to make sense as part of this package.
Right, I think for Linux it's ok to make both shortcuts available, as we do for Windows.
See https://en.wikipedia.org/wiki/Control-Y. I'll add an inline comment. |
ellatrix
commented
Jul 27, 2022
| * | ||
| * @return {boolean} True if MacOS; false otherwise. | ||
| */ | ||
| function isAppleOS( _window = window ) { |
There was a problem hiding this comment.
@talldan I reused the export form the key codes package for these two other instances. As you can see we're always making this check in the context of key codes, so I think it makes sense in this package.
ellatrix
force-pushed
the
add/redo-windows-shortcut
branch
from
f0ad11f
to
1d897e2
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #8921.
Why?
Ctrl+Yis the de-facto default shortcut for undo on Windows.How?
Exports
isAppleOsin the key codes package because it seems generally handy in the context of shortcuts.Testing Instructions
Check if
Ctrl+Yworks on Windows. Make sure it doesn't work on Mac.Screenshots or screencast