Fix isInputField

[ellatrix]

Description

Fixes #4268. I accidentally checked for lower case names in nodeName. 🙈 Adds tests too.

How Has This Been Tested?

Select a block, then select some text in an input field inside the block or in the inspector. The content of the section should be copied, not the whole block.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows has proper inline documentation.

[ellatrix]

Not sure about the tests btw, maybe that's a bit too much. :)

[mcsf]

🚢

Also, I think the tests are fine.

[aduth]

What should I expect as the result of isInputField given HTML:

<div contenteditable><span></span></div>

...and called as:

isInputField( document.querySelector( 'div > span' ) );

?

[ellatrix]

Since it’s not the input field itself, I guess false?

…

On Thu, 4 Jan 2018 at 21:29, Andrew Duthie ***@***.***> wrote: What should I expect as the result of isInputField given HTML: <div contenteditable><span></span></div> ...and called as: isInputField( document.querySelector( 'div > span' ) ); ? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#4271 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEfg6wxaK20QGcwLbK6rPggLG79pWrEbks5tHTShgaJpZM4RSWVm> .

[aduth]

Since it’s not the input field itself, I guess false?

Yeah, I guess the intention of the question is less "what would it return" (it returns false) and more: should it return false? Or should we consider the span to still be an "input" since it's technically editable?

Certainly an edge case, but one which I expect would be no fun to debug if it were encountered 😄

[ellatrix]

Hm, I would assume the person using isInputField is looking for the focusable input field. A span in side a contentEditable area is not an input field? 🙂