Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix isInputField #4271
Fixes #4268. I accidentally checked for lower case names in
How Has This Been Tested?
Select a block, then select some text in an input field inside the block or in the inspector. The content of the section should be copied, not the whole block.
referenced this pull request
Jan 3, 2018
Jan 4, 2018
Since it’s not the input field itself, I guess false?…
On Thu, 4 Jan 2018 at 21:29, Andrew Duthie ***@***.***> wrote: What should I expect as the result of isInputField given HTML: <div contenteditable><span></span></div> ...and called as: isInputField( document.querySelector( 'div > span' ) ); ? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#4271 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEfg6wxaK20QGcwLbK6rPggLG79pWrEbks5tHTShgaJpZM4RSWVm> .
Yeah, I guess the intention of the question is less "what would it return" (it returns
Certainly an edge case, but one which I expect would be no fun to debug if it were encountered