Remove duplicate speak calls from navigation block #43079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Code Quality
|
Size Change: -9 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes duplicate
speakcalls from the navigation block.Why?
Creating a notice using an action like
createWarningNoticeimplicitly callsspeak(unless thespeak: falsearg is passed), so the separate calls tospeakaren't required. I don't think there's any negative consequence to calling it twice, so this is a code quality improvement and not a bug fix.Testing Instructions
Prerequisites - use a screenreader, and ensure you have some classic menus.