New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paste from Slack: interpret paragraph markup #43114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +3.34 kB (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
priethor
added
[Type] Bug
An existing feature does not function as intended
[Feature] Raw Handling
Related to the ability to convert content to blocks, paste handling, etc
Backport to Gutenberg Minor Release
Pull request that needs to be backported to a Gutenberg minor release
labels
Aug 10, 2022
mcsf
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up and added integration tests!
priethor
pushed a commit
that referenced
this pull request
Aug 12, 2022
priethor
pushed a commit
that referenced
this pull request
Aug 12, 2022
Cherry-picked to the 13.8 branch and released in Gutenberg 13.8.2. ✅ |
priethor
removed
the
Backport to Gutenberg Minor Release
Pull request that needs to be backported to a Gutenberg minor release
label
Aug 12, 2022
Cherry-picked to the 13.9 branch and released in Gutenberg 13.9-rc2 ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Raw Handling
Related to the ability to convert content to blocks, paste handling, etc
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Slack gives us some weird markup for "paragraphs" (which are actually created by two line breaks).
This PR interprets that markup.
Why?
To make paste from Slack more smooth
How?
Adds a new paste rule
Testing Instructions
Create a message in Slackbot with two lines separated by two line breaks. Send it and copy paste the content in Gutenberg. The two lines should be separate paragraphs.
Screenshots or screencast