Cover image: added upload button. #4361
Conversation
jorgefilipecosta
added
[Type] Enhancement
|
It would be great if all these became an |
jorgefilipecosta
force-pushed
the
add/upload-button-cover-image
branch
from
e4f5e71
to
69d6743
Compare
blocks/image-placeholder/index.js
Outdated
| */ | ||
| import MediaUploadButton from '../media-upload-button'; | ||
|
|
||
| export default function ImagePlaceHolder( { className, setAttributes, icon, label, onSelectImage } ) { |
There was a problem hiding this comment.
Great work extracting this, there's something that bother me a bit about the setAttributes being passed here and also being passed to mediaUpload (probably the root issue).
Instead of passing setAttributes to mediaUpload, should we refactor it to pass something like onChange and onChange would be called with a single or multiple images (it's used in gallery aswell).
This would allow us to only pass onChange here.
The issue with the current approach is that this "reusable" component enforces the block using it to have certain attribute keys.
There was a problem hiding this comment.
I totally agree with this changes, the refactor should be applied in the media upload because it is there that we are using the attribute keys. I will add to this PR a refactor to the media upload as previous work.
There was a problem hiding this comment.
A refactor was applied to the mediaUpload. It is now more generic and does not contain block specific logic e.g: for the gallery.
The placeholder now does not receive setAttributes it just receives onSelectImage that is used for both uploaded and gallery images. An object is passed to function describing the image, the user of the component can pass a function that maps the image object to its attributes.
jorgefilipecosta
force-pushed
the
add/upload-button-cover-image
branch
2 times, most recently
from
82012dc
to
ccff0d4
Compare
jorgefilipecosta
force-pushed
the
add/upload-button-cover-image
branch
5 times, most recently
from
4507681
to
06984a4
Compare
jorgefilipecosta
force-pushed
the
add/upload-button-cover-image
branch
2 times, most recently
from
a24de71
to
0fd78d4
Compare
For consistency reasons with image block.
jorgefilipecosta
force-pushed
the
add/upload-button-cover-image
branch
from
0fd78d4
to
4cc25d4
Compare
mediaUpload now receives receives an array of files and a function that it calls with an array of objects representing the files uploaded. Logic specific to gallery and image blocks was removed from the function.
jorgefilipecosta
force-pushed
the
add/upload-button-cover-image
branch
from
4cc25d4
to
2d9b9c0
Compare
This PR adds an upload button to cover image to make it consistent with the image block.
Fixes: #4341
How Has This Been Tested?
Add a cover image, use the upload button select an image and verify the image was used in the cover image block.
Screenshots (jpeg or gifs if applicable):