New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover image: added upload button. #4361

Merged
merged 4 commits into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Jan 8, 2018

This PR adds an upload button to cover image to make it consistent with the image block.
Fixes: #4341

How Has This Been Tested?

Add a cover image, use the upload button select an image and verify the image was used in the cover image block.

Screenshots (jpeg or gifs if applicable):

screen shot 2018-01-08 at 23 01 15

@mtias

This comment has been minimized.

Show comment
Hide comment
@mtias

mtias Jan 9, 2018

Contributor

It would be great if all these became an ImagePlaceholder component that came with the upload buttons, drag area, etc. The text and title should probably be customizable.

Contributor

mtias commented Jan 9, 2018

It would be great if all these became an ImagePlaceholder component that came with the upload buttons, drag area, etc. The text and title should probably be customizable.

@youknowriad

This needs a rebase, but awesome work on this PR

jorgefilipecosta added some commits Jan 10, 2018

Refactored mediaUpload to be more generic.
mediaUpload now receives receives an array of files and a function that it calls with an array of objects representing the files uploaded. Logic specific to gallery and image blocks was removed from the function.

@jorgefilipecosta jorgefilipecosta merged commit 23bf408 into master Jan 11, 2018

3 checks passed

codecov/project 39.77% (+0.04%) compared to 175fc6d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the add/upload-button-cover-image branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment