Components: remove unused normalizeArrowKey utility function #43640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
normalizeArrowKeyis a utility function added in #33208 and needed by a component (TextInput) that was never added to the library, and is currently unused.It is not used by any component, and is not exported from the package. And probably it won't be useful in the future, as we should be using
KeyboardEvent.codeinstead of the deprecatedKeyboardEvent.keyCode.Why?
I came across this piece of dead code while working on refactoring away from all
KeyboardEvent.keyCodeand@wordpress/keycodescalls in the@wordpress/componentspackage/Testing Instructions
Make sure that the project builds correctly.