Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover: refactor to TypeScript #43823

Merged
merged 49 commits into from
Sep 6, 2022
Merged

Popover: refactor to TypeScript #43823

merged 49 commits into from
Sep 6, 2022

Commits on Sep 6, 2022

  1. Rename files

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    867c532 View commit details
    Browse the repository at this point in the history

  2. First iteration of Popover props

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a911e6a View commit details
    Browse the repository at this point in the history

  3. Add types to component and default export

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ddfe57b View commit details
    Browse the repository at this point in the history

  4. Type AnimatedWrapper, refactor logic to always render a motion.div

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7f4059b View commit details
    Browse the repository at this point in the history

  5. Remove unnused props from ArrowTriangle

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    ed5ace4 View commit details
    Browse the repository at this point in the history

  6. Use intermediate variable for flip/resize fallback values when `__uns… 

    …tableForcePosition` is passed
    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    e2f18b7 View commit details
    Browse the repository at this point in the history

  7. Type PopoverSlot

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    742c830 View commit details
    Browse the repository at this point in the history

  8. Type resize middleware

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0fd0d43 View commit details
    Browse the repository at this point in the history

  9. Type onDialogClose & related

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c095b2f View commit details
    Browse the repository at this point in the history

  10. Type middleware array

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b984ff7 View commit details
    Browse the repository at this point in the history

  11. Split and export different anchor ref types

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6263832 View commit details
    Browse the repository at this point in the history

  12. Type ownerDocument ev listeners useEffect

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    702f95c View commit details
    Browse the repository at this point in the history

  13. Type internal state and ref callbacks

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    d9cde6d View commit details
    Browse the repository at this point in the history

  14. Type mergedFloatingRef

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9ff0b8b View commit details
    Browse the repository at this point in the history

  15. Fix type error in AnimatedWrapper s style

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    67afd28 View commit details
    Browse the repository at this point in the history

  16. Type arrow styles

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    eccc7ca View commit details
    Browse the repository at this point in the history

  17. Simplify position pro definition

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0c8c527 View commit details
    Browse the repository at this point in the history

  18. Type placement-based utils

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    a7d16d3 View commit details
    Browse the repository at this point in the history

  19. Type getFrameOffset

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    39eb435 View commit details
    Browse the repository at this point in the history

  20. Type getReferenceOwnerDocument

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6e46741 View commit details
    Browse the repository at this point in the history

  21. Make top and bottom props on anchorRef mandatory

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b2698a0 View commit details
    Browse the repository at this point in the history

  22. Type getReferenceElement

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    62555b5 View commit details
    Browse the repository at this point in the history

  23. anchorRef.startContainer is never undefined

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    4b9aa59 View commit details
    Browse the repository at this point in the history

  24. No need to optional-chain anchorRef.current.ownerDocument

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    3d60bf9 View commit details
    Browse the repository at this point in the history

  25. Remove TODO

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    79c0918 View commit details
    Browse the repository at this point in the history

  26. Fix getFrameOffset signature

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    7b82718 View commit details
    Browse the repository at this point in the history

  27. Simplify anchorRef types

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    5feac47 View commit details
    Browse the repository at this point in the history

  28. Add type descriptions

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0d69c6e View commit details
    Browse the repository at this point in the history

  29. Type useDialog hook

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    448a8b0 View commit details
    Browse the repository at this point in the history

  30. Add @deprecated tag for the range prop

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    248522b View commit details
    Browse the repository at this point in the history

  31. Type Storybook examples

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    f885dd3 View commit details
    Browse the repository at this point in the history

  32. refactor BorderControl and BorderBoxControl

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    64b218f View commit details
    Browse the repository at this point in the history

  33. Add JSDoc description and example snippet to exported component

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    3102956 View commit details
    Browse the repository at this point in the history

  34. Add placement s default value

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    92c96e5 View commit details
    Browse the repository at this point in the history

  35. README

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    b571090 View commit details
    Browse the repository at this point in the history

  36. CHANGELOGs

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    bf068e9 View commit details
    Browse the repository at this point in the history

  37. Refine position types

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    969bd60 View commit details
    Browse the repository at this point in the history

  38. Type the shift prop, mark __unstableShift as deprecated

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    dec13b2 View commit details
    Browse the repository at this point in the history

  39. focusOnMount typo

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    fabedfa View commit details
    Browse the repository at this point in the history

  40. Fix onFocusOutside README type

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    031fea4 View commit details
    Browse the repository at this point in the history

  41. fix getAnchorRect README type

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    bf84afb View commit details
    Browse the repository at this point in the history

  42. Fix anchorRef README type

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    6c24c7b View commit details
    Browse the repository at this point in the history

  43. Fix children README type

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    8261fdf View commit details
    Browse the repository at this point in the history

  44. Fix isAlternate README type

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    e4807e0 View commit details
    Browse the repository at this point in the history

  45. Remove unstable props from README, add deprecated range prop

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    27875f8 View commit details
    Browse the repository at this point in the history

  46. Improve focusOnMount types on derived components

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    5754ee1 View commit details
    Browse the repository at this point in the history

  47. Do not display controls for children prop

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    25d4391 View commit details
    Browse the repository at this point in the history

  48. Storybook feedback

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    78a25e8 View commit details
    Browse the repository at this point in the history

  49. Restore they way popoverProps was passed in BorderControl

    @ciampo
    ciampo committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    dac81ea View commit details
    Browse the repository at this point in the history