Comment pagination blocks: Add spacing support #43905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -334 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
carolinan
added
[Block] Comments
carolinan
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
|
@c4rl0sbr4v0 I consider this to be low priority, but do you remember why the spacing between the comments pagination inner blocks where handled with both margins and block gap? Could this spacing be handled with block gap only? |
carolinan
added
the
[Status] Blocked
|
@carolinan I guess there is no specific reason for using both margins and the gap if this last one was enough. It could be our lack of knowledge about theming in this case. Feel free to update, as you are quite more experienced in themes! Also, we can ping @MaggieCabrera or @mikachan as Theme experts too. |
Looking at the styles that are output for the comments pagination elements, it looks like we can just use block gap here 👍 |
|
Flaky tests detected in b21c3e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5377524539
|
|
I can confirm that this is still blocked. The margins added through theme.json or global styles work in the site editor and block editor, but on the front they are overridden by the layout styles as described in this comment: #45107 (review) |
carolinan
added
the
Global Styles
|
When adding margin and padding to the comment pagination block via the global styles sidebar, I am now seeing the following: Site Editor, margin is not applied: Front, no issues: |
|
In classic themes that does not enable spacing settings, the following CSS is output on the front: and |
|
But this is the CSS output on the front in the same classic theme, Twenty Ten, when Gutenberg is deactivated. |
|
I give up for today 😆 But I don't think the issues in the classic theme that does not have a theme.json are introduced by this PR. The loading order of the CSS is different when Gutenberg is active. |
|
Hi @carolinan ! I've been away on paternity leave for a few time. How can I help you here? |
|
@c4rl0sbr4v0 I am not sure. The remaining issue is the CSS specificity, so it is bigger than this single PR... The block styles are being overwritten, and the CSS is different depending on what the theme type is, classic or block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds spacing block support to
Comments pagination, comments pagination next, previous and numbers.
Why?
So that users can adjust the spacing, and for consistency.
Related: #43243
How?
Adds spacing block support in block.json.
Testing Instructions
The testing steps are the same for the four blocks, test both individual blocks, global style settings, and theme.json style settings.
Continue to test the block's layout (spacing) settings in the global styles sidebar in the site editor.
Note that the comment pagination next/previous and numbers have the same names in the styles sidebar as the query pagination blocks. So if at first you fail, try the other.
Theme.json example code:
Screenshots or screencast