Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gutenberg_ prefix for theme_json_get_style_nodes filter #44949

Merged
merged 1 commit into from Oct 14, 2022

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Oct 13, 2022

What?

Updates the filter to match the name used in core.

See WordPress/wordpress-develop#3443.

Related to #44940.

Why?

We shouldn't be using different prefixes per environment—it's problematic for any consumer that want to use the filter.

How?

Renamed gutenberg_theme_json_get_style_nodes to wp_theme_json_get_style_nodes to match core.

@ajlende ajlende added the Backport from WordPress Core Pull request that needs to be backported to the a Gutenberg release from WordPress Core label Oct 13, 2022
@ajlende ajlende self-assigned this Oct 13, 2022
Copy link
Member

@SergeyBiryukov SergeyBiryukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me 👍

@ajlende ajlende merged commit a84db76 into trunk Oct 14, 2022
@ajlende ajlende deleted the fix/rename-style-nodes-filter branch October 14, 2022 16:05
@github-actions github-actions bot added this to the Gutenberg 14.4 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport from WordPress Core Pull request that needs to be backported to the a Gutenberg release from WordPress Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants