List view: Close after selecting block #45079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstine
added
[Type] Enhancement
|
Size Change: +47 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Hi @alexstine, Personally, I would prefer if the list view continues open even after we select a block there. My editor flow (mainly when designing things) is to use the list view to select a block and do something there at the block level and then select another block right away and do another thing there. I guess we need to make sure even if the list view is open, pressing the list view shortcut moves the focus there. Would that solve the a11y issues? |
|
I concur with @jorgefilipecosta that in my workflow, I pretty much always have the List View open when working in the Editor. If the view closed on each block selection I would be opening and closing the List View constantly 😂 This also might break the multi-select functionality that allows you to group, remove, etc. from the List View. That said, I definitely can see how improving the focus would be very helpful. |
|
Thanks all. I'll work on modifying the keyboard shortcut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #29466
After selecting a block from the list view, the list view should close that way it can be re-opened with the global keyboard shortcut. When the list view re-opens, focus is placed in the list view for all users, not just screen readers. This greatly improves the UX.
Why?
Once you select a block, there is no easy way to get to the list view sidebar again. This could be for sighted and even screen reader users. Sighted users could always navigate back to the sidebar with their mouse, but from a keyboard navigation perspective, there is not an easy way. See the linked issue for further discussion/details.
How?
I passed a callback function in to the
ListViewcomponent that will get called after a block is selected.Testing Instructions
Screenshots or screencast