Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing Flow: Trailing placeholder attempt 3 #4539

Merged
merged 18 commits into from
Jan 29, 2018
Merged

Writing Flow: Trailing placeholder attempt 3 #4539

merged 18 commits into from
Jan 29, 2018

Commits on Jan 29, 2018

  1. Editor: Bring back the trailing placeholder

    @youknowriad
    youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    46e45c5 View commit details
    Browse the repository at this point in the history

  2. Adding an inserter next to the last block

    @youknowriad
    youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    0bb22de View commit details
    Browse the repository at this point in the history

  3. Branch off of older version and ad side inserter

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    5f85d32 View commit details
    Browse the repository at this point in the history

  4. Polish ellipsis menu

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    2e9e089 View commit details
    Browse the repository at this point in the history

  5. Adjust side inserter further, make it hidden until parent is hovered.

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    220e1ef View commit details
    Browse the repository at this point in the history

  6. Adjust block padding math

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    3c75f31 View commit details
    Browse the repository at this point in the history

  7. Fix mobile.

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    b2ff784 View commit details
    Browse the repository at this point in the history

  8. Fix some pixel discrepancies.

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    0c61706 View commit details
    Browse the repository at this point in the history

  9. Final pixel adjustments.

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    c5b2ebb View commit details
    Browse the repository at this point in the history

  10. Adjust design of side inserter to be lighter 

    This brings us closer to the mockup. But in a slightly hacky way. Once #4512 is merged this should be refactored.
    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    b4eb981 View commit details
    Browse the repository at this point in the history

  11. Polish the left area a bit

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    7e83930 View commit details
    Browse the repository at this point in the history

  12. Fix some tests, some rebase issues and refactor 

    This tweaks the inserter to not be part of the mover control
    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    87b7211 View commit details
    Browse the repository at this point in the history

  13. Polish the appender so it's pixel perfect.

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    07e116f View commit details
    Browse the repository at this point in the history

  14. Change default appender to be input 

    This simplifies the trailing appender to be virtually the same as the first one, except with no placeholder text.

It simplifies the code, and it also addresses some accessibility concerns with aria labels, hover styles, tab into & write.
    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    0d2abc8 View commit details
    Browse the repository at this point in the history

  15. Fix test.

    @youknowriad
    Joen Asmussen authored and youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    aaa0ebc View commit details
    Browse the repository at this point in the history

  16. Side Inserter: Fix design post rebase

    @youknowriad
    youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    de1c9b5 View commit details
    Browse the repository at this point in the history

  17. Remove sibling inserter

    @youknowriad
    youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    308bc80 View commit details
    Browse the repository at this point in the history

  18. Side Inserter: Select the block when opening the inserter

    @youknowriad
    youknowriad committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    c17e331 View commit details
    Browse the repository at this point in the history