Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrips: Update verbiage and comments in install-node-nvm.sh script #4624

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Scrips: Update verbiage and comments in install-node-nvm.sh script #4624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bin/install-node-nvm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ if [ "$TRAVIS" != "true" ] && ! command_exists "nvm"; then
exit 1
fi

# Check if the current nvm version is up to date.
if [ "$TRAVIS" != "true" ] && [ $NVM_VERSION != "v$(nvm --version)" ]; then
echo -en $(status_message "Updating NVM..." )
download "https://raw.githubusercontent.com/creationix/nvm/$NVM_VERSION/install.sh" | bash >/dev/null 2>&1
Expand All @@ -57,7 +58,7 @@ if [ "$TRAVIS" != "true" ] && [ "$(nvm current)" != "$(nvm version-remote --lts)
nvm install >/dev/null 2>&1
echo ' done!'

echo -e $(warning_message "A new node version was install, please run this command to use it:" )
echo -e $(warning_message "A new node version was installed, please run this command to use it:" )
echo -e $(warning_message "$(action_format "nvm use")" )
echo -e $(warning_message "After that, re-run the setup script to continue." )
exit 1
Expand All @@ -67,7 +68,7 @@ fi
echo -e $(status_message "Installing and updating NPM packages..." )
npm install

# There was a bug in NPM that caused has changes in package-lock.json. Handle that.
# There was a bug in NPM that caused changes in package-lock.json. Handle that.
if [ "$TRAVIS" != "true" ] && ! git diff --exit-code package-lock.json >/dev/null; then
if ask "$(warning_message "Your package-lock.json changed, which may mean there's an issue with your NPM cache. Would you like to try and automatically clean it up?" )" N 10; then
rm -rf node_modules/
Expand Down