Reset the page between every performance test #46646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Dec 19, 2022
|
Any indication why perf tests started failing recently, if this is supposed to be the fix for them? |
|
Looking at the changes they seem fine; it'd be nice to have more in the commit message indicating what exactly was wrong and what this solves? Which metrics were thrown off by this? What is the proposed impact? I can get started measuring the impact on the Performance Tests runtime; guessing they'll be minimal. |
I saw these in a couple PRs, I don't know the cause of these yet. The current PR is as the description suggests just a small change to always start fresh in the editor between each metric. In trunk, some metrics like "inserter open", "list view open" relied on what was present on the editor before the test runs which is defined by the previous test in the file. |
youknowriad
force-pushed
the
refactor/post-editor-perf-test
branch
from
d7bb563
to
ec5b38c
Compare
this would have been gold in the commit message, which is why I asked 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In trunk, some performance tests start from an empty post while others just use what was already loaded in the editor (previous test). This is problematic if you want to run metrics in isolation and also can result in a metric impacting others. For more consistency and stability, this PR updates the test to always start fresh between metrics.
I don't expect any meaningful impact on the results as I tried to kept the same content in the post editor for each metric compared to trunk but surprises are possible.