[Block Library - Query Loop]: Fetch terms suggestions dynamically #46649
+104
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
jsnajdr,
ryanwelcher and
hellofromtonya
|
Size Change: +107 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
mcsf
reviewed
Dec 19, 2022
packages/block-library/src/query/edit/inspector-controls/taxonomy-controls.js
Outdated
Show resolved
Hide resolved
Mamaduka
approved these changes
Dec 20, 2022
ntsekouras
force-pushed
the
add/query-loop-terms-dynamic-suggestions-fetching
branch
from
89e573a
to
ce40b97
Compare
ntsekouras
deleted the
add/query-loop-terms-dynamic-suggestions-fetching
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #33581
Fixes: #41285
When there are more than 100 terms in any taxonomy, only 100 tags are available for filtering the Query Loop.
This PR changes the implementation for suggestions in terms in Query Loop filters to dynamically fetch terms based on the user input. Previously we fetched the first 100 results and would filter them by the user input, making it impossible to find terms in sites that have more than 100.
Testing Instructions