Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of WP_HTML_Tag_Processor in navigation-submenu block #47378

Closed
wants to merge 1 commit into from

Conversation

aristath
Copy link
Member

What?

Following the discussion on #47349, this PR removes the use of the WP_HTML_Tag_Processor object in the navigation-submenu block.
This was introduced in #40778 and can be replaced by a simple str_replace call.

Why?

See #47349 for details

How?

Replacing the call to WP_HTML_Tag_Processor with an str_replace() call. It's simple, effective, and it works.

@ockham
Copy link
Contributor

ockham commented Jan 24, 2023

Thank you very much, Ari!

Given the latest conversation on #47349, there's a chance that we'll end up merging WP_HTML_Tag_Processor in Core after all 😅 I'll reply there shortly; let's maybe hold off on this PR for now 😊

@ockham
Copy link
Contributor

ockham commented Jan 25, 2023

Update: We've discussed WP_HTML_Tag_Processor once more, and we've decided to include it in 6.2 after all 😊 This means we won't have to remove the dependency, and we can close this PR.

Thanks again, @aristath -- and sorry for the noise! 😅

@ockham ockham closed this Jan 25, 2023
@aristath aristath deleted the remove-tag-processor-nav-submenu branch January 26, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants