Page List: Add extra safety around warnings. #47603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +36 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1e1a4d0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4052776152
|
scruffian
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #46930 (comment).
It's possible to get the page list to throw an error when the user has a particular page structure as the code doesn't check if
parentPageDetails.title.renderedis defined before attempting to access it.How?
The fix is to add some extra safety to the warning message.
I've also added an extra message, as otherwise the block renders completely empty.
Testing Instructions
This PR: A notice displays "Page List: Cannot retrieve Pages."
In trunk: The block throws an error.
Screenshots or screencast
Before
After